🏡 index : ironmagma/quintodrome.git

package artwork

import (
	"context"
	"errors"
	"image"
	"image/jpeg"
	"image/png"
	"io"
	"os"
	"path/filepath"
	"time"

	_ "github.com/gen2brain/webp"
	"github.com/navidrome/navidrome/conf"
	"github.com/navidrome/navidrome/conf/configtest"
	"github.com/navidrome/navidrome/log"
	"github.com/navidrome/navidrome/model"
	"github.com/navidrome/navidrome/tests"
	. "github.com/onsi/ginkgo/v2"
	. "github.com/onsi/gomega"
)

var _ = Describe("Artwork", func() {
	var aw *artwork
	var ds model.DataStore
	var ffmpeg *tests.MockFFmpeg
	var folderRepo *fakeFolderRepo
	ctx := log.NewContext(context.TODO())
	var alOnlyEmbed, alEmbedNotFound, alOnlyExternal, alExternalNotFound, alMultipleCovers, alSingleDisc model.Album
	var arMultipleCovers model.Artist
	var mfWithEmbed, mfAnotherWithEmbed, mfWithoutEmbed, mfCorruptedCover model.MediaFile

	BeforeEach(func() {
		DeferCleanup(configtest.SetupConfig())
		conf.Server.ImageCacheSize = "0" // Disable cache
		conf.Server.CoverArtPriority = "folder.*, cover.*, embedded , front.*"

		folderRepo = &fakeFolderRepo{}
		libRepo := &tests.MockLibraryRepo{}
		repoRoot, _ := os.Getwd()
		libRepo.SetData(model.Libraries{{ID: 0, Path: testFileLibPath(repoRoot)}})
		ds = &tests.MockDataStore{
			MockedTranscoding: &tests.MockTranscodingRepo{},
			MockedFolder:      folderRepo,
			MockedLibrary:     libRepo,
		}
		// Paths use forward slashes because the scanner stores fs.FS-relative paths in the DB.
		alOnlyEmbed = model.Album{ID: "222", Name: "Only embed", EmbedArtPath: "tests/fixtures/artist/an-album/test.mp3", FolderIDs: []string{"f1"}}
		alEmbedNotFound = model.Album{ID: "333", Name: "Embed not found", EmbedArtPath: "tests/fixtures/NON_EXISTENT.mp3", FolderIDs: []string{"f1"}}
		alOnlyExternal = model.Album{ID: "444", Name: "Only external", FolderIDs: []string{"f1"}, Discs: model.Discs{1: "", 2: ""}}
		alExternalNotFound = model.Album{ID: "555", Name: "External not found", FolderIDs: []string{"f2"}}
		alSingleDisc = model.Album{ID: "888", Name: "Single disc", FolderIDs: []string{"f1"}, Discs: model.Discs{1: ""}}
		arMultipleCovers = model.Artist{ID: "777", Name: "All options"}
		alMultipleCovers = model.Album{
			ID:            "666",
			Name:          "All options",
			EmbedArtPath:  "tests/fixtures/artist/an-album/test.mp3",
			FolderIDs:     []string{"f1"},
			AlbumArtistID: "777",
		}
		mfWithEmbed = model.MediaFile{ID: "22", Path: "tests/fixtures/test.mp3", HasCoverArt: true, AlbumID: "222"}
		mfAnotherWithEmbed = model.MediaFile{ID: "23", Path: "tests/fixtures/artist/an-album/test.mp3", HasCoverArt: true, AlbumID: "666"}
		mfWithoutEmbed = model.MediaFile{ID: "44", Path: "tests/fixtures/test.ogg", AlbumID: "444"}
		mfCorruptedCover = model.MediaFile{ID: "45", Path: "tests/fixtures/test.ogg", HasCoverArt: true, AlbumID: "444"}

		cache := GetImageCache()
		ffmpeg = tests.NewMockFFmpeg("content from ffmpeg")
		aw = NewArtwork(ds, cache, ffmpeg, nil).(*artwork)
	})

	Describe("albumArtworkReader", func() {
		Context("ID not found", func() {
			It("returns ErrNotFound if album is not in the DB", func() {
				_, err := newAlbumArtworkReader(ctx, aw, model.MustParseArtworkID("al-NOT-FOUND"), nil)
				Expect(err).To(MatchError(model.ErrNotFound))
			})
		})
		Context("Embed images", func() {
			BeforeEach(func() {
				folderRepo.result = nil
				ds.Album(ctx).(*tests.MockAlbumRepo).SetData(model.Albums{
					alOnlyEmbed,
					alEmbedNotFound,
				})
			})
			It("returns embed cover", func() {
				aw, err := newAlbumArtworkReader(ctx, aw, alOnlyEmbed.CoverArtID(), nil)
				Expect(err).ToNot(HaveOccurred())
				_, path, err := aw.Reader(ctx)
				Expect(err).ToNot(HaveOccurred())
				Expect(path).To(Equal("tests/fixtures/artist/an-album/test.mp3"))
			})
			It("returns ErrUnavailable if embed path is not available", func() {
				ffmpeg.Error = errors.New("not available")
				aw, err := newAlbumArtworkReader(ctx, aw, alEmbedNotFound.CoverArtID(), nil)
				Expect(err).ToNot(HaveOccurred())
				_, _, err = aw.Reader(ctx)
				Expect(err).To(MatchError(ErrUnavailable))
			})
		})
		Context("External images", func() {
			BeforeEach(func() {
				folderRepo.result = []model.Folder{}
				ds.Album(ctx).(*tests.MockAlbumRepo).SetData(model.Albums{
					alOnlyExternal,
					alExternalNotFound,
				})
			})
			It("returns external cover", func() {
				folderRepo.result = []model.Folder{{
					Path:       "tests/fixtures/artist/an-album",
					ImageFiles: []string{"front.png"},
				}}
				aw, err := newAlbumArtworkReader(ctx, aw, alOnlyExternal.CoverArtID(), nil)
				Expect(err).ToNot(HaveOccurred())
				_, path, err := aw.Reader(ctx)
				Expect(err).ToNot(HaveOccurred())
				Expect(path).To(Equal("tests/fixtures/artist/an-album/front.png"))
			})
			It("returns ErrUnavailable if external file is not available", func() {
				folderRepo.result = []model.Folder{}
				aw, err := newAlbumArtworkReader(ctx, aw, alExternalNotFound.CoverArtID(), nil)
				Expect(err).ToNot(HaveOccurred())
				_, _, err = aw.Reader(ctx)
				Expect(err).To(MatchError(ErrUnavailable))
			})
		})
		Context("Multiple covers", func() {
			BeforeEach(func() {
				folderRepo.result = []model.Folder{{
					Path:       "tests/fixtures/artist/an-album",
					ImageFiles: []string{"cover.jpg", "front.png", "artist.png"},
				}}
				ds.Album(ctx).(*tests.MockAlbumRepo).SetData(model.Albums{
					alMultipleCovers,
				})
			})
			DescribeTable("CoverArtPriority",
				func(priority string, expected string) {
					conf.Server.CoverArtPriority = priority
					aw, err := newAlbumArtworkReader(ctx, aw, alMultipleCovers.CoverArtID(), nil)
					Expect(err).ToNot(HaveOccurred())
					_, path, err := aw.Reader(ctx)
					Expect(err).ToNot(HaveOccurred())
					Expect(path).To(Equal(expected))
				},
				Entry(nil, " folder.* , cover.*,embedded,front.*", "tests/fixtures/artist/an-album/cover.jpg"),
				Entry(nil, "front.* , cover.*, embedded ,folder.*", "tests/fixtures/artist/an-album/front.png"),
				Entry(nil, " embedded , front.* , cover.*,folder.*", "tests/fixtures/artist/an-album/test.mp3"),
			)
		})
		Context("LastUpdated", func() {
			// Regression test for #5377: LastUpdated feeds the HTTP Last-Modified header.
			// It must return max(album.UpdatedAt, ImagesUpdatedAt) so browsers revalidate
			// cached cover art when only the image file changes.
			now := time.Now().Truncate(time.Second)
			DescribeTable("returns the max of album.UpdatedAt and ImagesUpdatedAt",
				func(albumUpdatedAt, imagesUpdatedAt, expected time.Time) {
					album := model.Album{ID: "al1", UpdatedAt: albumUpdatedAt}
					folderRepo.result = []model.Folder{{ImagesUpdatedAt: imagesUpdatedAt}}
					ds.Album(ctx).(*tests.MockAlbumRepo).SetData(model.Albums{album})

					ar, err := newAlbumArtworkReader(ctx, aw, album.CoverArtID(), nil)
					Expect(err).ToNot(HaveOccurred())
					Expect(ar.LastUpdated()).To(Equal(expected))
				},
				Entry("album newer than images", now, now.Add(-1*time.Hour), now),
				Entry("images newer than album", now.Add(-24*time.Hour), now.Add(-1*time.Hour), now.Add(-1*time.Hour)),
				Entry("equal timestamps", now, now, now),
			)
		})
	})
	Describe("discArtworkReader", func() {
		Context("LastUpdated", func() {
			// Regression test for #5377: same bug as albumArtworkReader — disc covers
			// must also revalidate when the image file changes, not only when media files do.
			now := time.Now().Truncate(time.Second)
			DescribeTable("returns the max of album.UpdatedAt and ImagesUpdatedAt",
				func(albumUpdatedAt, imagesUpdatedAt, expected time.Time) {
					album := model.Album{ID: "al1", UpdatedAt: albumUpdatedAt}
					folderRepo.result = []model.Folder{{ImagesUpdatedAt: imagesUpdatedAt}}
					ds.Album(ctx).(*tests.MockAlbumRepo).SetData(model.Albums{album})
					ds.MediaFile(ctx).(*tests.MockMediaFileRepo).SetData(model.MediaFiles{
						{ID: "mf1", AlbumID: "al1", DiscNumber: 1, Path: "tests/fixtures/test.mp3"},
					})

					artID := model.NewArtworkID(model.KindDiscArtwork, model.DiscArtworkID("al1", 1), nil)
					dr, err := newDiscArtworkReader(ctx, aw, artID)
					Expect(err).ToNot(HaveOccurred())
					Expect(dr.LastUpdated()).To(Equal(expected))
				},
				Entry("album newer than images", now, now.Add(-1*time.Hour), now),
				Entry("images newer than album", now.Add(-24*time.Hour), now.Add(-1*time.Hour), now.Add(-1*time.Hour)),
				Entry("equal timestamps", now, now, now),
			)
		})
	})
	Describe("artistArtworkReader", func() {
		Context("Multiple covers", func() {
			BeforeEach(func() {
				repoRoot, err := os.Getwd()
				Expect(err).ToNot(HaveOccurred())
				folderRepo.result = []model.Folder{{
					LibraryPath: testFileLibPath(repoRoot),
					Path:        "tests/fixtures/artist/an-album",
					ImageFiles:  []string{"artist.png"},
				}}
				ds.Artist(ctx).(*tests.MockArtistRepo).SetData(model.Artists{
					arMultipleCovers,
				})
				ds.Album(ctx).(*tests.MockAlbumRepo).SetData(model.Albums{
					alMultipleCovers,
				})
				ds.MediaFile(ctx).(*tests.MockMediaFileRepo).SetData(model.MediaFiles{
					mfAnotherWithEmbed,
				})
			})
			DescribeTable("ArtistArtPriority",
				func(priority string, expected string) {
					conf.Server.ArtistArtPriority = priority
					aw, err := newArtistArtworkReader(ctx, aw, arMultipleCovers.CoverArtID(), nil)
					Expect(err).ToNot(HaveOccurred())
					_, path, err := aw.Reader(ctx)
					Expect(err).ToNot(HaveOccurred())
					Expect(filepath.ToSlash(path)).To(HaveSuffix(expected))
				},
				Entry(nil, " folder.* , artist.*,album/artist.*", "tests/fixtures/artist/artist.jpg"),
				Entry(nil, "album/artist.*, folder.*,artist.*", "tests/fixtures/artist/an-album/artist.png"),
			)
		})
	})
	Describe("mediafileArtworkReader", func() {
		Context("ID not found", func() {
			It("returns ErrNotFound if mediafile is not in the DB", func() {
				_, err := newMediafileArtworkReader(ctx, aw, model.MustParseArtworkID("mf-NOT-FOUND"))
				Expect(err).To(MatchError(model.ErrNotFound))
			})
		})
		Context("Embed images", func() {
			BeforeEach(func() {
				folderRepo.result = []model.Folder{{
					Path:       "tests/fixtures/artist/an-album",
					ImageFiles: []string{"front.png"},
				}}
				ds.Album(ctx).(*tests.MockAlbumRepo).SetData(model.Albums{
					alOnlyEmbed,
					alOnlyExternal,
					alSingleDisc,
				})
				ds.MediaFile(ctx).(*tests.MockMediaFileRepo).SetData(model.MediaFiles{
					mfWithEmbed,
					mfWithoutEmbed,
					mfCorruptedCover,
				})
			})
			It("returns embed cover", func() {
				aw, err := newMediafileArtworkReader(ctx, aw, mfWithEmbed.CoverArtID())
				Expect(err).ToNot(HaveOccurred())
				_, path, err := aw.Reader(ctx)
				Expect(err).ToNot(HaveOccurred())
				Expect(path).To(Equal("tests/fixtures/test.mp3"))
			})
			It("returns embed cover if successfully extracted by ffmpeg", func() {
				aw, err := newMediafileArtworkReader(ctx, aw, mfCorruptedCover.CoverArtID())
				Expect(err).ToNot(HaveOccurred())
				r, path, err := aw.Reader(ctx)
				Expect(err).ToNot(HaveOccurred())
				data, _ := io.ReadAll(r)
				Expect(data).ToNot(BeEmpty())
				Expect(path).To(Equal("tests/fixtures/test.ogg"))
			})
			It("returns album cover if cannot read embed artwork", func() {
				// Force fromTag to fail
				mfCorruptedCover.Path = "tests/fixtures/DOES_NOT_EXIST.ogg"
				Expect(ds.MediaFile(ctx).(*tests.MockMediaFileRepo).Put(&mfCorruptedCover)).To(Succeed())
				// Simulate ffmpeg error
				ffmpeg.Error = errors.New("not available")

				aw, err := newMediafileArtworkReader(ctx, aw, mfCorruptedCover.CoverArtID())
				Expect(err).ToNot(HaveOccurred())
				_, path, err := aw.Reader(ctx)
				Expect(err).ToNot(HaveOccurred())
				Expect(path).To(Equal("al-444_0"))
			})
			It("returns album cover if media file has no cover art", func() {
				aw, err := newMediafileArtworkReader(ctx, aw, model.MustParseArtworkID("mf-"+mfWithoutEmbed.ID))
				Expect(err).ToNot(HaveOccurred())
				_, path, err := aw.Reader(ctx)
				Expect(err).ToNot(HaveOccurred())
				Expect(path).To(Equal("al-444_0"))
			})
			It("falls back to disc cover art when media file has a disc number on a multi-disc album", func() {
				mfWithDisc := model.MediaFile{ID: "46", Path: "tests/fixtures/test.ogg", AlbumID: "444", DiscNumber: 2}
				Expect(ds.MediaFile(ctx).(*tests.MockMediaFileRepo).Put(&mfWithDisc)).To(Succeed())

				aw, err := newMediafileArtworkReader(ctx, aw, model.MustParseArtworkID("mf-"+mfWithDisc.ID))
				Expect(err).ToNot(HaveOccurred())
				_, path, err := aw.Reader(ctx)
				Expect(err).ToNot(HaveOccurred())
				// Should fall back to disc art, which itself falls back to album art
				Expect(path).To(Equal("dc-444:2_0"))
			})
			It("falls back to album cover art for single-disc albums even with a disc number", func() {
				mfOnSingleDisc := model.MediaFile{ID: "47", Path: "tests/fixtures/test.ogg", AlbumID: "888", DiscNumber: 1}
				Expect(ds.MediaFile(ctx).(*tests.MockMediaFileRepo).Put(&mfOnSingleDisc)).To(Succeed())

				aw, err := newMediafileArtworkReader(ctx, aw, model.MustParseArtworkID("mf-"+mfOnSingleDisc.ID))
				Expect(err).ToNot(HaveOccurred())
				_, path, err := aw.Reader(ctx)
				Expect(err).ToNot(HaveOccurred())
				// Single-disc album should skip disc art and go straight to album art
				Expect(path).To(Equal("al-888_0"))
			})
		})
	})
	Describe("playlistArtworkReader", func() {
		Describe("findPlaylistSidecarPath", func() {
			It("discovers sidecar image next to playlist file", func() {
				tmpDir := GinkgoT().TempDir()
				plsPath := filepath.Join(tmpDir, "MyPlaylist.m3u")
				imgPath := filepath.Join(tmpDir, "MyPlaylist.jpg")
				Expect(os.WriteFile(plsPath, []byte("#EXTM3U\n"), 0600)).To(Succeed())
				Expect(os.WriteFile(imgPath, []byte("fake image"), 0600)).To(Succeed())

				result := findPlaylistSidecarPath(GinkgoT().Context(), plsPath)
				Expect(result).To(Equal(imgPath))
			})

			It("returns empty string when no sidecar image exists", func() {
				tmpDir := GinkgoT().TempDir()
				plsPath := filepath.Join(tmpDir, "MyPlaylist.m3u")
				Expect(os.WriteFile(plsPath, []byte("#EXTM3U\n"), 0600)).To(Succeed())

				result := findPlaylistSidecarPath(GinkgoT().Context(), plsPath)
				Expect(result).To(BeEmpty())
			})

			It("returns empty string when playlist has no path", func() {
				result := findPlaylistSidecarPath(GinkgoT().Context(), "")
				Expect(result).To(BeEmpty())
			})

			It("finds sidecar with different case base name", func() {
				tmpDir := GinkgoT().TempDir()
				plsPath := filepath.Join(tmpDir, "myplaylist.m3u")
				imgPath := filepath.Join(tmpDir, "MyPlaylist.jpg")
				Expect(os.WriteFile(plsPath, []byte("#EXTM3U\n"), 0600)).To(Succeed())
				Expect(os.WriteFile(imgPath, []byte("fake image"), 0600)).To(Succeed())

				result := findPlaylistSidecarPath(GinkgoT().Context(), plsPath)
				Expect(result).To(Equal(imgPath))
			})
		})

		Describe("fromPlaylistExternalImage", func() {
			It("opens local path from ExternalImageURL", func() {
				tmpDir := GinkgoT().TempDir()
				imgPath := filepath.Join(tmpDir, "cover.jpg")
				Expect(os.WriteFile(imgPath, []byte("external image data"), 0600)).To(Succeed())

				reader := &playlistArtworkReader{
					pl: model.Playlist{ExternalImageURL: imgPath},
				}
				r, path, err := reader.fromPlaylistExternalImage(ctx)()
				Expect(err).ToNot(HaveOccurred())
				Expect(r).ToNot(BeNil())
				Expect(path).To(Equal(imgPath))
				data, _ := io.ReadAll(r)
				Expect(string(data)).To(Equal("external image data"))
				r.Close()
			})

			It("returns nil when ExternalImageURL is empty", func() {
				reader := &playlistArtworkReader{
					pl: model.Playlist{ExternalImageURL: ""},
				}
				r, path, err := reader.fromPlaylistExternalImage(ctx)()
				Expect(err).ToNot(HaveOccurred())
				Expect(r).To(BeNil())
				Expect(path).To(BeEmpty())
			})

			It("returns error when local file does not exist", func() {
				reader := &playlistArtworkReader{
					pl: model.Playlist{ExternalImageURL: "/non/existent/path/cover.jpg"},
				}
				r, _, err := reader.fromPlaylistExternalImage(ctx)()
				Expect(err).To(HaveOccurred())
				Expect(r).To(BeNil())
			})

			It("skips HTTP URL when EnableM3UExternalAlbumArt is false", func() {
				conf.Server.EnableM3UExternalAlbumArt = false

				reader := &playlistArtworkReader{
					pl: model.Playlist{ExternalImageURL: "https://example.com/cover.jpg"},
				}
				r, path, err := reader.fromPlaylistExternalImage(ctx)()
				Expect(err).ToNot(HaveOccurred())
				Expect(r).To(BeNil())
				Expect(path).To(BeEmpty())
			})

			It("still opens local path when EnableM3UExternalAlbumArt is false", func() {
				conf.Server.EnableM3UExternalAlbumArt = false

				tmpDir := GinkgoT().TempDir()
				imgPath := filepath.Join(tmpDir, "cover.jpg")
				Expect(os.WriteFile(imgPath, []byte("local image"), 0600)).To(Succeed())

				reader := &playlistArtworkReader{
					pl: model.Playlist{ExternalImageURL: imgPath},
				}
				r, path, err := reader.fromPlaylistExternalImage(ctx)()
				Expect(err).ToNot(HaveOccurred())
				Expect(r).ToNot(BeNil())
				Expect(path).To(Equal(imgPath))
				r.Close()
			})
		})
	})

	Describe("resizedArtworkReader", func() {
		BeforeEach(func() {
			folderRepo.result = []model.Folder{{
				Path:       "tests/fixtures/artist/an-album",
				ImageFiles: []string{"cover.jpg", "front.png"},
			}}
			ds.Album(ctx).(*tests.MockAlbumRepo).SetData(model.Albums{
				alMultipleCovers,
			})
		})
		When("Square is false", func() {
			It("returns PNG if original image is a PNG", func() {
				conf.Server.CoverArtPriority = "front.png"
				r, _, err := aw.Get(context.Background(), alMultipleCovers.CoverArtID(), 15, false)
				Expect(err).ToNot(HaveOccurred())

				img, format, err := image.Decode(r)
				Expect(err).ToNot(HaveOccurred())
				Expect(format).To(Equal("png"))
				Expect(img.Bounds().Size().X).To(Equal(15))
				Expect(img.Bounds().Size().Y).To(Equal(15))
			})
			It("returns JPEG if original image is not a PNG", func() {
				conf.Server.CoverArtPriority = "cover.jpg"
				r, _, err := aw.Get(context.Background(), alMultipleCovers.CoverArtID(), 200, false)
				Expect(err).ToNot(HaveOccurred())

				img, format, err := image.Decode(r)
				Expect(format).To(Equal("jpeg"))
				Expect(err).ToNot(HaveOccurred())
				Expect(img.Bounds().Size().X).To(Equal(200))
				Expect(img.Bounds().Size().Y).To(Equal(200))
			})
		})
		When("When square is true", func() {
			var alCover model.Album

			DescribeTable("resize",
				func(srcFormat string, expectedFormat string, landscape bool, size int) {
					coverFileName := "cover." + srcFormat
					dirName := createImage(srcFormat, landscape, size)
					alCover = model.Album{
						ID:        "444",
						Name:      "Only external",
						FolderIDs: []string{"tmp"},
					}
					folderRepo.result = []model.Folder{{ImageFiles: []string{coverFileName}}}
					rootLibRepo := &tests.MockLibraryRepo{}
					rootLibRepo.SetData(model.Libraries{{ID: 0, Path: testFileLibPath(dirName)}})
					ds.(*tests.MockDataStore).MockedLibrary = rootLibRepo
					ds.Album(ctx).(*tests.MockAlbumRepo).SetData(model.Albums{
						alCover,
					})

					conf.Server.CoverArtPriority = coverFileName
					r, _, err := aw.Get(context.Background(), alCover.CoverArtID(), size, true)
					Expect(err).ToNot(HaveOccurred())

					img, format, err := image.Decode(r)
					Expect(err).ToNot(HaveOccurred())
					Expect(format).To(Equal(expectedFormat))
					Expect(img.Bounds().Size().X).To(Equal(size))
					Expect(img.Bounds().Size().Y).To(Equal(size))
				},
				Entry("portrait png image", "png", "png", false, 200),
				Entry("landscape png image", "png", "png", true, 200),
				Entry("portrait jpg image", "jpg", "png", false, 200),
				Entry("landscape jpg image", "jpg", "png", true, 200),
			)
		})
		When("EnableWebPEncoding is true and square is false", func() {
			BeforeEach(func() {
				conf.Server.EnableWebPEncoding = true
			})
			It("returns WebP even if original image is a PNG", func() {
				conf.Server.CoverArtPriority = "front.png"
				r, _, err := aw.Get(context.Background(), alMultipleCovers.CoverArtID(), 15, false)
				Expect(err).ToNot(HaveOccurred())

				img, format, err := image.Decode(r)
				Expect(err).ToNot(HaveOccurred())
				Expect(format).To(Equal("webp"))
				Expect(img.Bounds().Size().X).To(Equal(15))
				Expect(img.Bounds().Size().Y).To(Equal(15))
			})
			It("returns WebP if original image is not a PNG", func() {
				conf.Server.CoverArtPriority = "cover.jpg"
				r, _, err := aw.Get(context.Background(), alMultipleCovers.CoverArtID(), 200, false)
				Expect(err).ToNot(HaveOccurred())

				img, format, err := image.Decode(r)
				Expect(format).To(Equal("webp"))
				Expect(err).ToNot(HaveOccurred())
				Expect(img.Bounds().Size().X).To(Equal(200))
				Expect(img.Bounds().Size().Y).To(Equal(200))
			})
		})
		When("EnableWebPEncoding is false and square is false", func() {
			BeforeEach(func() {
				conf.Server.EnableWebPEncoding = false
			})
			It("returns PNG if original image is a PNG", func() {
				conf.Server.CoverArtPriority = "front.png"
				r, _, err := aw.Get(context.Background(), alMultipleCovers.CoverArtID(), 15, false)
				Expect(err).ToNot(HaveOccurred())

				img, format, err := image.Decode(r)
				Expect(err).ToNot(HaveOccurred())
				Expect(format).To(Equal("png"))
				Expect(img.Bounds().Size().X).To(Equal(15))
				Expect(img.Bounds().Size().Y).To(Equal(15))
			})
			It("returns JPEG if original image is a JPG", func() {
				conf.Server.CoverArtPriority = "cover.jpg"
				r, _, err := aw.Get(context.Background(), alMultipleCovers.CoverArtID(), 200, false)
				Expect(err).ToNot(HaveOccurred())

				img, format, err := image.Decode(r)
				Expect(err).ToNot(HaveOccurred())
				Expect(format).To(Equal("jpeg"))
				Expect(img.Bounds().Size().X).To(Equal(200))
				Expect(img.Bounds().Size().Y).To(Equal(200))
			})
		})
		When("EnableWebPEncoding is false and square is true", func() {
			var alCover model.Album

			BeforeEach(func() {
				conf.Server.EnableWebPEncoding = false
			})
			It("returns PNG for square mode", func() {
				dirName := createImage("png", false, 200)
				alCover = model.Album{
					ID:        "444",
					Name:      "Only external",
					FolderIDs: []string{"tmp"},
				}
				folderRepo.result = []model.Folder{{ImageFiles: []string{"cover.png"}}}
				rootLibRepo := &tests.MockLibraryRepo{}
				rootLibRepo.SetData(model.Libraries{{ID: 0, Path: testFileLibPath(dirName)}})
				ds.(*tests.MockDataStore).MockedLibrary = rootLibRepo
				ds.Album(ctx).(*tests.MockAlbumRepo).SetData(model.Albums{alCover})

				conf.Server.CoverArtPriority = "cover.png"
				r, _, err := aw.Get(context.Background(), alCover.CoverArtID(), 200, true)
				Expect(err).ToNot(HaveOccurred())

				img, format, err := image.Decode(r)
				Expect(err).ToNot(HaveOccurred())
				Expect(format).To(Equal("png"))
				Expect(img.Bounds().Size().X).To(Equal(200))
				Expect(img.Bounds().Size().Y).To(Equal(200))
			})
		})
		When("Requested size is larger than original", func() {
			It("clamps size to original dimensions", func() {
				conf.Server.CoverArtPriority = "front.png"
				// front.png is 16x16, requesting 99999 should return at original size
				r, _, err := aw.Get(context.Background(), alMultipleCovers.CoverArtID(), 99999, false)
				Expect(err).ToNot(HaveOccurred())

				img, _, err := image.Decode(r)
				Expect(err).ToNot(HaveOccurred())
				// Should be clamped to original size (16), not 99999
				Expect(img.Bounds().Size().X).To(Equal(16))
				Expect(img.Bounds().Size().Y).To(Equal(16))
			})

			It("clamps square size to original dimensions", func() {
				conf.Server.CoverArtPriority = "front.png"
				// front.png is 16x16, requesting 99999 with square should return 16x16 square
				r, _, err := aw.Get(context.Background(), alMultipleCovers.CoverArtID(), 99999, true)
				Expect(err).ToNot(HaveOccurred())

				img, _, err := image.Decode(r)
				Expect(err).ToNot(HaveOccurred())
				// Should be clamped to original size (16), not 99999
				Expect(img.Bounds().Size().X).To(Equal(16))
				Expect(img.Bounds().Size().Y).To(Equal(16))
			})
		})
	})
})

func createImage(format string, landscape bool, size int) string {
	var img image.Image

	if landscape {
		img = image.NewRGBA(image.Rect(0, 0, size, size/2))
	} else {
		img = image.NewRGBA(image.Rect(0, 0, size/2, size))
	}

	tmpDir := GinkgoT().TempDir()
	f, _ := os.Create(filepath.Join(tmpDir, "cover."+format))
	defer f.Close()
	switch format {
	case "png":
		_ = png.Encode(f, img)
	case "jpg":
		_ = jpeg.Encode(f, img, &jpeg.Options{Quality: 75})
	}

	return tmpDir
}